Subject: Re: bug in XFree86 4.1.0 with Rage 128 driver?
From: Kevin Hendricks (khendricks@ivey.uwo.ca)
Date: Thu Oct 11 2001 - 07:27:41 MDT
Hi Dan,
On Thursday, October 11, 2001, at 01:21 AM, Dan Burcaw wrote:
>
>> Dan and Olaf, if you haven't gone to press with new releases, you
>> probably
>> should include this one in your next respin builds of XFree86 4.1.0
>
>
> We have, but I'll be sure to include this for errata.
I typed the wrong yellowdog-devel e-mail address (used
lists.linuxppc.org incorrectly! - Freudian slip.. ;-)
So unless you monitor linuxppc-dev here are some things you might want
to know:
- Michel is still unsure this is a bug.
- Olaf just wrote that it fixed his problem on the pismo and that it has
already been committed to CVS (I assume he means XFree86 CVS).
- I personally can't see how using a variable that has not been
initialized in an "if" is anything other than a bug.
- I have tested the patch myself and it seems to have fixed the
problems with OOo segfaulting under XFree 4.1.0 (when it didn't under
XF 4.0.2)
Thanks,
Kevin
>> Michel will you see that this makes it into the next XF 4.X release for
>> us.
>>
>> Thanks,
>>
>> Kevin
>>
>>> Will you please look at the following diff from Xrender.c in XF 4.0.2
>>> to
>>> Xrender.c in XF410. It looks very strange. Starting in lie 190.
>>> It seems they no longer Xmalloc a value for xFormat (they now use
>>> xData)
>>> but just one line later they check if xFormat is zero.
>>>
>>> The code before that in XRenderQueryFormats() doesNOT set a value for
>>> xFormat at all after its is declared and before it is tested.
>>>
>>> I think someone just missed changing and xFormat to an xData unless I
>>> am
>>> missing something here.
>>>
>>> Kevin
>>>
>>>
>>>
>>> @@ -190,19 +191,20 @@
>>> rep.numScreens * sizeof (xPictScreen) +
>>> rep.numDepths * sizeof (xPictDepth) +
>>> rep.numVisuals * sizeof (xPictVisual));
>>> - xFormat = (xPictFormInfo *) Xmalloc (rlength);
>>> + xData = (void *) Xmalloc (rlength);
>>>
>>> if (!xri || !xFormat)
>>> {
>>> if (xri) Xfree (xri);
>>> - if (xFormat) Xfree (xFormat);
>>> + if (xData) Xfree (xData);
>>> _XEatData (dpy, rlength);
>>> UnlockDisplay (dpy);
>>> SyncHandle ();
>>> return 0;
>>
>>
>>
>
> --
>
> Regards,
> Dan Burcaw
> Terra Soft Solutions, Inc.
> http://www.terrasoftsolutions.com/
>
This archive was generated by hypermail 2a24 : Thu Oct 11 2001 - 06:42:15 MDT