logic bug in dma_wait()

Olaf Hering olh at suse.de
Tue Jun 21 08:02:56 MDT 2005


Samuel,

maybe someone dragged you away from the keyboard while you hacked on
src/drivers/dbdma.c:dma_wait()
How is ret.ret supposed to be initialized. Perhaps like that?


 src/drivers/dbdma.c |    1 +
 1 files changed, 1 insertion(+)

Index: mol-0.9.70/src/drivers/dbdma.c
===================================================================
--- mol-0.9.70.orig/src/drivers/dbdma.c
+++ mol-0.9.70/src/drivers/dbdma.c
@@ -1035,6 +1035,7 @@ dma_wait( int irq, int flags, struct tim
 
 	if( cond ){
 		ret.next = *ret_chain;
+		ret.ret = ret.next->ret;
 		*ret_chain = ret.next;
 
 		if( abstimeout == NULL ){


More information about the mol-general mailing list